DbInfo simplification#16248
Conversation
github-actions
Bot
added
the
test native
| .setHost("ss.host") | ||
| .setPort(1444) | ||
| .setName("ssinstance") | ||
| .setDb("ssdb") |
There was a problem hiding this comment.
Elsewhere name seems to be database name but here it is an instance name, is this correct?
There was a problem hiding this comment.
I don't think it's correct, but it's existing behavior. I've fixed it under stable semconv flag in #16277.
There was a problem hiding this comment.
https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/database/database-spans.md says
In some SQL databases, the database name to be used is called "schema name". In case there are multiple layers that could be considered for database name (e.g. Oracle instance name and schema name), the database name to be used is the more specific layer (e.g. Oracle schema name).
Based on that I think we shouldn't bother with the instance name at all.
2 participants
This is a preliminary simplification before adding support for
db.namespaceto DbInfo parsing.